[tor-bugs] #30359 [Core Tor/Stem]: Stem PEP8 compliant

[Tor Bug Tracker & Wiki]

#30359: Stem PEP8 compliant
---------------------------+------------------------
 Reporter:  0xrichard      |          Owner:  atagar
     Type:  enhancement    |         Status:  new
 Priority:  Low            |      Milestone:
Component:  Core Tor/Stem  |        Version:
 Severity:  Minor          |     Resolution:
 Keywords:  dev            |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------

Comment (by atagar):

 Hi 0xrichard, thanks for the patch! In this case though I kinda wish you'd
 talked with me before investing your time. Stem runs pycodestyle as part
 of its tests, and already complies with PEP8 in most regards. The ways in
 which it differs (for instance, two space indentation) is intentional...

 https://gitweb.torproject.org/stem.git/tree/test/settings.cfg#n95

 If you'd care to push for us to be more compliant that's fine, but the
 approach we should take is...

 1. Decide which of the above PEP8 compliance rules you feel strongly that
 we should follow.

 2. File a ticket to discuss why you think we should change it.

 3. Once we've established a consensus on following the rule remove its
 ignore configuration from the file mentioned above. Stem's tests should
 now cite all the spots where we don't comply with it.

 4. Make the adjustments (like your patch does) to correct the compliance
 issues.

 Does that make sense?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30359#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online