[tor-bugs] #29958 [Core Tor/Tor]: Error: SIZEOF_UNSIGNED_INT is undefined

[Tor Bug Tracker & Wiki]

#29958: Error: SIZEOF_UNSIGNED_INT is undefined
-----------------------------------------+---------------------------------
 Reporter:  teor                         |          Owner:  teor
     Type:  defect                       |         Status:  needs_review
 Priority:  Medium                       |      Milestone:  Tor:
                                         |  0.4.1.x-final
Component:  Core Tor/Tor                 |        Version:  Tor:
                                         |  unspecified
 Severity:  Normal                       |     Resolution:
 Keywords:  fast-fix, compilation-error  |  Actual Points:  0.1
Parent ID:                               |         Points:  0.1
 Reviewer:                               |        Sponsor:
-----------------------------------------+---------------------------------
Changes (by teor):

 * keywords:   => fast-fix, compilation-error
 * status:  assigned => needs_review


Comment:

 See my PR:
 https://github.com/torproject/tor/pull/871

 This is a bugfix on #29537, which is not in any released version of Tor,
 so it does not need a changes file.

 My (Apple) version of clang caught this error:
 {{{
 $ clang --version
 Apple LLVM version 10.0.0 (clang-1000.11.45.2)
 }}}

 But our CI versions of clang and gcc did not:
 {{{
 $ clang --version
 clang version 5.0.0 (tags/RELEASE_500/final)
 $ gcc --version
 gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
 $ clang --version
 Apple LLVM version 9.1.0 (clang-902.0.39.2)
 > Execute-Bash "${env:target}-gcc --version"
 x86_64-w64-mingw32-gcc.exe (Rev3, Built by MSYS2 project) 8.2.0
 i686-w64-mingw32-gcc.exe (Rev2, Built by MSYS2 project) 7.3.0
 }}}

 I think that's probably because they are too old?

 If someone wants to dig further, here is the compiler documentation:
 https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
 https://clang.llvm.org/docs/DiagnosticsReference.html#wundef

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29958#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online