[tor-bugs] #24546 [Core Tor/Tor]: Use tor_addr_is_v4() rather than family, or reject all v6-mapped IPv4 addresses

[Tor Bug Tracker & Wiki]

#24546: Use tor_addr_is_v4() rather than family, or reject all v6-mapped IPv4
addresses
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  unspecified
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-dirauth, ipv6,                   |  Actual Points:  1
  033-triage-20180320, 033-removed-20180320,     |
  035-triaged-in-20180711,                       |
  040-deferred-20190220                          |
Parent ID:                                       |         Points:  1
 Reviewer:  ahf, teor                            |        Sponsor:
                                                 |  SponsorV-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision
 * actualpoints:   => 1


Comment:

 Thanks, that looks much better.

 Now that we have removed special handling for v4-mapped IPv6 addresses,
 there's some more code that we can remove. And we need to move the
 IPV6_V6ONLY code so that it applies to all sockets. See my detailed
 comments on the pull request.

 Please make any further changes in separate commits on the same branch,
 then push the branch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24546#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online