[tor-bugs] #29825 [Applications/Tor Browser]: Intelligently insert the Security Level button to the user's taskbar rather than resetting to default on upgrade

[Tor Bug Tracker & Wiki]

#29825: Intelligently insert the Security Level button to the user's taskbar rather
than resetting to default on upgrade
-------------------------------------------------+-------------------------
 Reporter:  pospeselr                            |          Owner:
                                                 |  pospeselr
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  TorBrowserTeam201903, tbb-8.5-must-  |  Actual Points:
  alpha                                          |
Parent ID:  #25658                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mcs):

 * status:  needs_review => needs_revision
 * keywords:  TorBrowserTeam201903R, tbb-8.5-must-alpha =>
     TorBrowserTeam201903, tbb-8.5-must-alpha


Comment:

 This looks good and it seems to work. Kathy and I just found a few nits.

 In the commit message:
 * s/to the right of/after/ (that way the commit message will be correct
 for RTL languages as well)
 * s/urlbar bar/url bar/

 In the patch:
 * Should we preserve the #13378 comment? I think it might still be
 relevant but I did not look at the patch from that ticket.
 * Maybe rename `placeButtonBesideUrlbar()` to `placeButtonAfterUrlBar()`
 and add a blank line after its definition.
 * In or near the `if urlbar isn't present` comment, please mention that
 the UI does not allow users to remove the URL bar (which means we are very
 unlikely to end up putting our icons at the beginning of the toolbar).
 * In that same comment, I suggest s/front of/beginning of/

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29825#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online