[tor-bugs] #22029 [Core Tor/Tor]: Allow ed25519 keys to be banned in the approved-routers file

[Tor Bug Tracker & Wiki]

#22029: Allow ed25519 keys to be banned in the approved-routers file
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  034-triage-20180328,                 |  Actual Points:
  034-removed-20180328                           |
Parent ID:                                       |         Points:  1
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:34 neel]:
 > I have created tests for the ed25519 and RSA functions. However, this
 did require moving some code from `process_descs.c` to `process_descs.h`
 so it can be used by the test.

 Thanks!

 I'd like to see a test for dirserv_load_fingerprint_file(), because the
 memory safety bugs were in that function. The existing test for
 dirserv_read_measured_bandwidth() is a good example of a unit test that
 reads a file.

 You force-pushed your changes over the old branch. When you did that,
 GitHub deleted my old review comments. I also can't tell which code I have
 already reviewed, and which code has been changed by your most recent
 changes. I don't have time to do a full review of your branch this week,
 so I'll have a look at it next week.

 In future, please add commits to the branch, rather than force-pushing
 your changes. When people review your tor pull requests, please add new
 commits for any pull request changes. Then reviewers won't have to do full
 reviews every time you make a change.

 If you want to change an existing commit, you can add fixup commits using:
 {{{
 git commit --fixup (existing commit hash)
 }}}
 Then we will squash before we merge,

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22029#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online