[tor-bugs] #29813 [Core Tor/Tor]: Add unmeasured and vote Line KeyValues in the bandwidth-file-spec
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Mar 21 12:08:32 UTC 2019
#29813: Add unmeasured and vote Line KeyValues in the bandwidth-file-spec
-------------------------------------------------+-------------------------
Reporter: juga | Owner: juga
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.4.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-spec, bandwidth-file-spec, tor- | Actual Points:
bwauth |
Parent ID: #28563 | Points: 1
Reviewer: nickm, teor | Sponsor:
-------------------------------------------------+-------------------------
Comment (by juga):
Replying to [comment:10 teor]:
> There is one typo in the spec, I added a comment on the pull request.
made other fixup
>
> I think we can merge this change when #29806 merges.
ok
>
> Why do you want to wait until the next sbws release?
i thought nickm was refering to sbws with:
> but we will need to change the listed versions when we merge this.
because of
https://github.com/torproject/torspec/pull/64/commits/171daa9b2d819c8aea963a557f82891fdeb2670f
#diff-824f4c7404328d8aa1101d74ba36884dL699
But he might have mean Tor version.
I changed 1.1.X by 1.1.0, didn't realize that doesn't matter there'll be a
1.1.1 later, this change will be included in 1.1.0.
So yes, we don't need to wait for sbws relase.
> If we keep this pull request open, and you make another pull request on
torspec master, they might have conflicts.
agree
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29813#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list