[tor-bugs] #28636 [Core Tor/Tor]: Address WTF-PAD comments by Nick (2018-11-27 over IRC)

[Tor Bug Tracker & Wiki]

#28636: Address WTF-PAD comments by Nick (2018-11-27 over IRC)
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,        |  Actual Points:
  padding, 041-proposed, network-team-           |
  roadmap-2019-Q1Q2                              |
Parent ID:  #28632                               |         Points:  3
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor2
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:19 nickm]:
 > Hi!  I left two comments.  One should be easy to fix, but the one about
 dormant mode should be less so.
 >
 > If the dormant-mode change is hard, then I'd suggest that you rebase the
 branch to include a fix for the RNG issue, and remove the dormant-mode
 change.  We can merge the branch after that, and you can do the dormant-
 mode thing in a separate branch.  Sound ok?

 Thanks for the review.

 I fixed the RNG issue, and added a fixup with a minimal fix for the
 dormant-mode (after discussion with Mike). I also opened #29821 for
 implementing circuit padding in dormant mode the proper way.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28636#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online