[tor-bugs] #29818 [Applications/Tor Browser]: adapt #13379 patch for 68esr

[Tor Bug Tracker & Wiki]

#29818: adapt #13379 patch for 68esr
------------------------------------------+--------------------------------
     Reporter:  mcs                       |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:  tbb-update,f68-esr
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+--------------------------------
 In https://bugzilla.mozilla.org/show_bug.cgi?id=1434033, Mozilla removed
 the use of LD_LIBRARY_PATH (which is used in non-macOS and non-Windows
 Firefox to ensure that the updater can located NSS related shared
 libraries). Instead, the Firefox build now adds `-rpath=$ORIGIN` in
 `LDFLAGS`.

 For Tor Browser, we need a similar solution for Windows and macOS because
 we define MAR_NSS on all platforms (we define MAR_NSS so that we use NSS
 for MAR-related crypto on all platforms rather than relying on OS-provided
 libraries). Therefore, we will need to adapt our #13379 patch to account
 for Mozilla's change.

 Current (Tor Browser 8.5a9) patch:
 https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-60.6.0esr-8.5-1&id=c17b8a3fbcd19230706f295a00ce955c1bcf90b9

 Related Firefox bugs:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1434033
 https://bugzilla.mozilla.org/show_bug.cgi?id=1434666

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29818>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online