[tor-bugs] #29136 [Core Tor/Tor]: PT_LOG and PT_STATUS event fields unspecifed

[Tor Bug Tracker & Wiki]

#29136: PT_LOG and PT_STATUS event fields unspecifed
----------------------------------------+----------------------------------
 Reporter:  atagar                      |          Owner:  ahf
     Type:  defect                      |         Status:
                                        |  needs_information
 Priority:  High                        |      Milestone:  Tor:
                                        |  0.4.0.x-final
Component:  Core Tor/Tor                |        Version:
 Severity:  Normal                      |     Resolution:
 Keywords:  tor-spec, tor-pt, 040-must  |  Actual Points:
Parent ID:                              |         Points:
 Reviewer:                              |        Sponsor:
----------------------------------------+----------------------------------
Changes (by ahf):

 * status:  assigned => needs_information


Comment:

 I'm not a big fan of specifying the same structures both places, but I
 think we should extend control spec with information about the SEVERITY of
 the message in PT_LOG. Then I think that message type would be complete.

 For PT_STATUS I think you should wait with doing anything fancy handling
 for now. We still don't have any PT's that emits anything useful here. If
 you want to implement some basic handling for this in stem, I suggest you
 emit an event which contains a dictionary of strings to string and write a
 parser for the serialization format we use (see tor's kv_line
 implementation).

 atagar: Would an acceptable fix for this ticket be to specify SEVERITY for
 PT_LOG? As far as I can tell that is the only piece missing in control-
 spec.txt to be able to implement a PT_LOG handler purely from reading the
 control-spec.txt itself without ever having a look at the PT
 specification.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29136#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online