[tor-bugs] #28563 [Core Tor/sbws]: Work out how sbws can report excluded relays in the bandwidth file

[Tor Bug Tracker & Wiki]

#28563: Work out how sbws can report excluded relays in the bandwidth file
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  sbws:
                                                 |  1.1.0
Component:  Core Tor/sbws                        |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-bwauth, sbws-1.0-must-           |  Actual Points:
  moved-20181128, sbws-11x-final-                |
  removed-20190312, sbws-110-proposed, changes-  |
  version-minor                                  |
Parent ID:  #28547                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by juga):

 Replying to [comment:14 teor]:

 > Tor ignores lines without a "bw=" key. But Tor 0.3.5 and later log an
 "Incomplete bandwidth file" warning for every incomplete line, every time
 they parse the file. That's not ok: we can not fill up authority operators
 logs with warnings.

 Sorry, i forgot about the warning.

 > Instead, you could use "bw=0 unmeasured=1 vote=0" and patch tor so that
 it ignores relay lines with "vote=0". Can you open another ticket for this
 Tor change?

 We have always say to do not give "bw=0" but "bw=1" because 0 can cause
 problems in Tor.
 Shouldn't "bw=0" be "bw=1"?.

 > Tor versions without the patch will give more 0 votes to unmeasured
 relays, so they will get lower bandwidth values in the consensus. That's
 ok.
 >
 > We might want to vote 0 for unmeasured relays in a future sbws or tor
 version.

 Hmm you mean to vote that the relay has 0 bandwidth?, right? (not to don't
 vote for the unmeasured relay).

 > That's why I added the "unmeasured=1" key. But it's not a change I want
 to make now, because you only have 10 paid days left. Can you open another
 ticket for this sbws change?

 Hmm, if i add "unmeasured=1" and make a Tor patch that ignores lines with
 "unmeasured=1", then we do not need to add "vote=0" and in a future Tor
 version we can still change Tor to vote on those lines, right?.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28563#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online