[tor-bugs] #28565 [Core Tor/sbws]: Report excluded results in a relay's bandwidth line

[Tor Bug Tracker & Wiki]

#28565: Report excluded results in a relay's bandwidth line
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  juga
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  sbws:
                                                 |  1.1.0
Component:  Core Tor/sbws                        |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-bwauth, sbws-1.0-must-           |  Actual Points:
  moved-20181128, sbws-11x-final-                |
  removed-20190312, sbws-110-proposed, changes-  |
  version-minor                                  |
Parent ID:  #28547                               |         Points:  1
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:16 juga]:
 > Replying to [comment:15 teor]:
 > > Here are some specific things to fix:
 > >
 > > * You made the bandwidth file header count relay exclusions, not
 result exclusions. That is a good choice: anyone who wants to know result
 totals can just add all the relay-level results. But the key names, key
 documentation, and comments need to say what you are counting.
 > >
 > > * It's not clear to me what each key is meant to be counting. Please
 update the spec in #29775, or write comments that define each kind of
 failure and each key (or both).
 >
 > I added fixups extending documentation.
 > TBH, i was minimizing documentation because i think we should work on
 #28684, which would change part of the documentation (and code).

 Ok, I have done a review on the code.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28565#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online