[tor-bugs] #28656 [Core Tor/Tor]: Bug: src/feature/nodelist/nodelist.c:2501: compute_frac_paths_available : Non-fatal assertion !(f_exit > 0.0) failed.

[Tor Bug Tracker & Wiki]

#28656: Bug: src/feature/nodelist/nodelist.c:2501: compute_frac_paths_available :
Non-fatal assertion !(f_exit > 0.0) failed.
-------------------------------------------------+-------------------------
 Reporter:  meejah                               |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.5.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  consider-backport-after-2019-03-19,  |  Actual Points:  0.1
  backport-before-0359, regression, 035-rc-      |
  blocker?, 035-backport, postfreeze-ok,         |
  040-must                                       |
Parent ID:                                       |         Points:  0.1
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  regression, 035-rc-blocker?, 035-backport, postfreeze-ok,
     040-must =>
     consider-backport-after-2019-03-19, backport-before-0359, regression,
     035-rc-blocker?, 035-backport, postfreeze-ok, 040-must


Comment:

 Replying to [comment:14 catalyst]:
 > Replying to [comment:13 nickm]:
 > > Okay, I've squashed the branch as bug28656_035_squashed, and made a
 new PR as https://github.com/torproject/tor/pull/798 .  Merging to 0.4.0
 and forward.  Marking for possible backport.
 > Backport pull request looks good. I have no strong opinions either way
 about backporting it to 0.3.5. Has anyone reported it triggering on 0.3.5?

 Yes, #29658 is a report on 0.3.5.8.

 And it was introduced in 0.3.5.1-alpha, so we don't need to backport any
 further:

 Replying to [comment:9 teor]:
 > This bug was introduced in #27237 in 0.3.5.1-alpha, due to an unexpected
 interaction with #27236 in 0.3.4.7-rc. See the comments in the pull
 request for details.

 (I haven't seen any reports earlier than 0.3.5.)

 Here's my backport assessment:

 This patch modifies application code by removing a BUG() warning and
 simplifying a condition into an equivalent condition. It affects 1 code
 line and a few comment lines.

 It is a low risk, obviously beneficial change. We have two (or three) bug
 reports on 0.3.5.8, 0.4.0.0-alpha-dev, and 0.4.0.1-alpha-dev.

 I'd like to backport it after a few working days in nightly, and before
 the next 0.3.5 release.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28656#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online