[tor-bugs] #29734 [Obfuscation/Snowflake]: Broker should receive country stats information from Proxy and Client

[Tor Bug Tracker & Wiki]

#29734: Broker should receive country stats information from Proxy and Client
-------------------------------------+--------------------------------
 Reporter:  cohosh                   |          Owner:  cohosh
     Type:  enhancement              |         Status:  needs_revision
 Priority:  Medium                   |      Milestone:
Component:  Obfuscation/Snowflake    |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  snowflake, geoip, stats  |  Actual Points:
Parent ID:  #29207                   |         Points:  1
 Reviewer:  ahf                      |        Sponsor:  Sponsor19
-------------------------------------+--------------------------------

Comment (by cohosh):

 > One way, if we're comfortable relying on Debian dependencies, is to ask
 the operator to install ​tor-geoipdb or ​geoip-database package.

 > We should make the path to the two GeoIP databases configurable (either
 via a command line parameter and/or a small config file?)

 I think this is the best of both worlds:
 https://github.com/cohosh/snowflake/commit/fbb87b508641bbbcfd3163d1f2a43b9aff4e0085

 The broker now allows the operator to pass in a path to geop files (for
 IPv4 and IPv6) as command-line arguments. The default is the install
 location of the debian tor-geoip package. If an invalid filename is
 provided (or none are provided and the package is not installed), the
 table will fail to load but not cause any crashes. There's a test for that
 here:
 https://github.com/cohosh/snowflake/commit/09dd27f9408b1ff3ff916e374bcd5f659ad5b26b

 > In the tests, I would also test an address that maps to "" and perhaps
 special cases like 127.0.0.1, 0.0.0.0, 255.255.255.255.

 Thanks! Got some bugs :) Here's the tests and fixes:
 https://github.com/cohosh/snowflake/commit/be4d245375722d958dd85f1a53849cdc37b3382b

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29734#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online