[tor-bugs] #29221 [Core Tor/Tor]: Tooling to track code-style/best-practices violations

[Tor Bug Tracker & Wiki]

#29221: Tooling to track code-style/best-practices violations
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  reopened
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  network-team-roadmap-2019-Q1Q2       |  Actual Points:  4
  teor-merge                                     |
Parent ID:                                       |         Points:  3
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  closed => reopened
 * resolution:  implemented =>


Comment:

 This script breaks jenkins on master due to a python error:
 {{{
 23:19:11 python ../tor/scripts/maint/practracker/practracker.py ../tor
 23:19:11 Traceback (most recent call last):
 23:19:11   File "../tor/scripts/maint/practracker/practracker.py", line
 25, in <module>
 23:19:11     import problem
 23:19:11   File "/srv/jenkins-workspace/workspace/tor-ci-linux-
 master/ARCHITECTURE/amd64/SUITE/stretch/tor/scripts/maint/practracker/problem.py",
 line 27
 23:19:11     print("No exception file provided", file=sys.stderr)
 23:19:11                                             ^
 23:19:11 SyntaxError: invalid syntax
 23:19:11 Makefile:19273: recipe for target 'check-best-practices' failed
 23:19:11 make[1]: *** [check-best-practices] Error 1
 }}}
 https://jenkins.torproject.org/job/tor-ci-linux-
 master/ARCHITECTURE=amd64,SUITE=stretch/3830/consoleFull
 #188818640921ba4c2d-fbf2-4975-9955-c2fe5cc665f5

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29221#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online