[tor-bugs] #29712 [Core Tor/sbws]: sbws should use 1024 to convert kilobytes to bytes

[Tor Bug Tracker & Wiki]

#29712: sbws should use 1024 to convert kilobytes to bytes
---------------------------+-----------------------------------
 Reporter:  teor           |          Owner:  (none)
     Type:  defect         |         Status:  closed
 Priority:  Low            |      Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |        Version:
 Severity:  Minor          |     Resolution:  not a bug
 Keywords:                 |  Actual Points:
Parent ID:                 |         Points:  0.2
 Reviewer:                 |        Sponsor:
---------------------------+-----------------------------------
Changes (by teor):

 * status:  new => closed
 * resolution:   => not a bug


Comment:

 Replying to [comment:2 starlight]:
 > Network bandwidth measurements are by convention represented in KB, MB,
 GB units etc. rather than KiB, MiB, Gib.  One example is Linux traffic
 control.  Torflow and other Tor software apply KB with the notable
 exception of Atlas, which IMO is incorrect.

 You're right, Torflow and pytorctl use 1000:
 https://gitweb.torproject.org/torflow.git/tree/NetworkScanners/BwAuthority/aggregate.py#n62
 https://gitweb.torproject.org/pytorctl.git/tree/TorCtl.py#n1221

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29712#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online