[tor-bugs] #29707 [Core Tor/sbws]: sbws does not scale consensus bandwidths to bytes before using them

[Tor Bug Tracker & Wiki]

#29707: sbws does not scale consensus bandwidths to bytes before using them
---------------------------+-----------------------------
 Reporter:  teor           |          Owner:  (none)
     Type:  defect         |         Status:  merge_ready
 Priority:  Medium         |      Milestone:
Component:  Core Tor/sbws  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+-----------------------------

Comment (by juga):

 Replying to [comment:1 juga]:
 > > Here's how we could avoid bugs like this in future:
 > > * We should add some unit tests that only work when this bug is fixed
 >
 > This is hard to do rigth now in unit test because RelayList has
 controller has mandatory argument. [0]
 > I started to mock it to create a Relay instance, then realized that
 creating stem's RouterStatusEntryV3 and RelayDescriptor accept different
 formats for fingerprint and signing key, so have to do several
 conversions.

 Created #29717.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29707#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online