[tor-bugs] #29707 [Core Tor/sbws]: sbws does not scale consensus bandwidths to bytes before using them

[Tor Bug Tracker & Wiki]

#29707: sbws does not scale consensus bandwidths to bytes before using them
---------------------------+-----------------------------
 Reporter:  teor           |          Owner:  (none)
     Type:  defect         |         Status:  merge_ready
 Priority:  Medium         |      Milestone:
Component:  Core Tor/sbws  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+-----------------------------

Comment (by juga):

 Replying to [comment:2 teor]:
 > Thanks, looks good!
 >
 > I opened #29712 to use 1024 to convert kilobytes to bytes.

 I'm quite sure Tor reports consensus bandwidth in kilobytes, not
 kibibytes:
 https://github.com/torproject/tor/blob/master/src/feature/dirauth/bwauth.c#L191,
 https://github.com/torproject/torspec/blob/master/dir-spec.txt#L2387

 > but the difference between 1000 and 1024 is not very important, because
 bandwidth measurements are only 20-59% accurate anyway.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29707#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online