[tor-bugs] #28525 [Core Tor/Tor]: Make tor_addr_is_internal_() aware of RFC 6598 (Carrier Grade NAT/Large Scale NAT) IPv4 Ranges

[Tor Bug Tracker & Wiki]

#28525: Make tor_addr_is_internal_() aware of RFC 6598 (Carrier Grade NAT/Large
Scale NAT) IPv4 Ranges
-------------------------------------------------+-------------------------
 Reporter:  neel                                 |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ipv6, 040-deferred-20190220,         |  Actual Points:
  040-backport, 035-backport, 034-backport,      |
  029-backport, security-low, asn-merge          |
Parent ID:                                       |         Points:
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_review => merge_ready
 * keywords:
     ipv6, 040-deferred-20190220, 040-backport, 035-backport, 034-backport,
     029-backport, security-low
     =>
     ipv6, 040-deferred-20190220, 040-backport, 035-backport, 034-backport,
     029-backport, security-low, asn-merge
 * milestone:  Tor: 0.4.1.x-final => Tor: 0.4.0.x-final


Comment:

 Okay, it looks good.  asn, please merge PR 763 above to 0.4.0 and forward?
 Then I suggest we let it cook for a while before backporting: I think that
 if this patch causes any problems, they will be subtle and take some time
 to notice.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28525#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online