[tor-bugs] #28525 [Core Tor/Tor]: Make tor_addr_is_internal_() aware of RFC 6598 (Carrier Grade NAT/Large Scale NAT) IPv4 Ranges

[Tor Bug Tracker & Wiki]

#28525: Make tor_addr_is_internal_() aware of RFC 6598 (Carrier Grade NAT/Large
Scale NAT) IPv4 Ranges
-------------------------------------------------+-------------------------
 Reporter:  neel                                 |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ipv6, 040-deferred-20190220,         |  Actual Points:
  040-backport, 035-backport, 034-backport,      |
  029-backport, security-low                     |
Parent ID:                                       |         Points:
 Reviewer:  nickm, teor                          |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Seems good to me.

 The cherry-pick to 0.2.9 is here:
 ​https://github.com/torproject/tor/pull/762

 There is a non-trivial merge to 0.3.5 here:
 ​https://github.com/torproject/tor/pull/763
 (The function before tor_addr_is_internal_() in 0.2.9 was moved to another
 file in 0.3.5.)

 I need nickm to review the cherry-pick and merge, because I'll be
 backporting them to 0.2.9 and 0.3.5. (After someone else merges to 0.4.0
 and master.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28525#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online