[tor-bugs] #30578 [Core Tor/Tor]: The circuitpadding_circuitsetup_machine test: Re-enable, remove, re-document, or ___?
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Jun 24 22:09:28 UTC 2019
#30578: The circuitpadding_circuitsetup_machine test: Re-enable, remove, re-
document, or ___?
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: asn
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: circuitpadding, 041-should, | Actual Points:
hopefully-easy, wtf-pad |
Parent ID: | Points:
Reviewer: asn | Sponsor:
| Sponsor2
-------------------------------------------------+-------------------------
Changes (by mikeperry):
* reviewer: mikeperry => asn
Comment:
Ok, I fixed the test and resolved the flapping issue. Shifting the
circuitsetup machine by 2ms ensures that the call of
timers_advaance_and_run(1) from circuit_package_relay_cell_mock() does not
trigger the circuitsetup relay side machine to send padding (which was the
problem).
https://github.com/torproject/tor/pull/1141
I am going to switch reviewer back to asn for the test flapping fix
commits. The rest look good to me.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30578#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list