[tor-bugs] #30920 [Core Tor/Tor]: Detect uint64 overflow in config_parse_units()

[Tor Bug Tracker & Wiki]

#30920: Detect uint64 overflow in config_parse_units()
---------------------------+------------------------------------
 Reporter:  nickm          |          Owner:  (none)
     Type:  defect         |         Status:  new
 Priority:  Low            |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |        Version:
 Severity:  Minor          |     Resolution:
 Keywords:  easy overflow  |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:6 guigom]:
 > Is the unit test expected to be inside `test_confparse.c` testing
 `config_parse_units()` ?

 I think Nick will do that test in #30893 and #30864.

 > Or create a separate test file that just tests the new multiplication
 in, for example, `test_muldiv.c`

 Just the new function is fine.

 The addsub tests are in test_util.c, so the muldiv tests can go in there
 as well.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30920#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online