[tor-bugs] #30733 [Core Tor/sbws]: sbws does not detect changes in descriptor bandwidth values

[Tor Bug Tracker & Wiki]

#30733: sbws does not detect changes in descriptor bandwidth values
-----------------------------------+-----------------------------------
 Reporter:  starlight              |          Owner:  juga
     Type:  defect                 |         Status:  needs_revision
 Priority:  Very High              |      Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws          |        Version:  sbws: 1.1.0
 Severity:  Critical               |     Resolution:
 Keywords:  sbws-majority-blocker  |  Actual Points:
Parent ID:                         |         Points:
 Reviewer:                         |        Sponsor:
-----------------------------------+-----------------------------------

Comment (by teor):

 Replying to [comment:28 juga]:
 >
 > So maybe the descriptors where not being fetch with lot of delay, but
 some Fetch* options will ensure that they are actually recent. After a
 conversation with arma in irc, i'm just not sure that which Fetch* options
 we really need.

 * we use FetchUselessDescriptors in sbws to make sure tor keeps on
 downloading descriptors, even if sbws is idle
 * sbws does not need FetchDirInfoExtraEarly, but if we want it to respond
 to MaxcAdvertisedBandwidth changes as soon as possible, we should use it
 * FetchDirInfoEarly is redundant when FetchDirInfoExtraEarly is set, so we
 can remove it

 Now is a good time to change the comments in #30733, so we know why sbws
 is using each option, next time someone asks these questions.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30733#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online