[tor-bugs] #27503 [Applications/Tor Browser]: Disabling accessibility on Windows breaks screen readers

[Tor Bug Tracker & Wiki]

#27503: Disabling accessibility on Windows breaks screen readers
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  pospeselr
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,      |  Actual Points:
  GeorgKoppen201903, tbb-8.5-must,               |
  TorBrowserTeam201906R                          |
Parent ID:                                       |         Points:
 Reviewer:  boklm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by cypherpunks):

 Reader's questions (will be removed soon):

 Can `nullptr` be used?

 https://github.com/pospeselr/wine/commit/b7aec156edc46528e90338bf56bfef0ceaca4217
 Different Wine-Bug?

 https://github.com/pospeselr/wine/commit/7a77bb55dff25254b26309a56575f93586eb0203
 " inline" instead of "inline "?
 /* FIXME: do we need to handle call_as? */

 https://github.com/pospeselr/wine/commit/c2d320d79644536ad988bda863b6f689451ee4e0
 {{{
     if (name && (t = find_type(name, namespace, tsENUM)))
         return t;
 }}}
 Is that coding style acceptable?
 Also
 https://github.com/pospeselr/wine/blob/2bf54a0f57566ad7b27194c5f45ccb895cb275ac/tools/widl/header.c#L506

 https://github.com/pospeselr/wine/commit/8e043b2f955d76fbf11285e5477d97d89f5065c4
 #diff-e75b8f9447cd0082fdc2e72d13b6f240R36
 No need to move `*`?

 https://github.com/pospeselr/wine/commit/a901af46040902d43d8ed0f70702d0a2f589fb15
 #diff-8905c813ddc5a5cf9d568bae351c24e5R2401
 `element` here, but `elem` in all other places? Maybe, some better names?

 https://github.com/pospeselr/wine/commit/2bf54a0f57566ad7b27194c5f45ccb895cb275ac
 #diff-8d894b6473d010f03261aa6855bc65fdR64
 Better naming than adding `2`?

 https://github.com/pospeselr/wine/commit/26df75e01e1313fd6f8d3fc8cb91ddd5678068dd
 #diff-e75b8f9447cd0082fdc2e72d13b6f240L56
 Fixed?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27503#comment:69>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online