[tor-bugs] #30334 [Applications/Tor Browser]: build_go_lib for executables?

[Tor Bug Tracker & Wiki]

#30334: build_go_lib for executables?
--------------------------------------+--------------------------
 Reporter:  JeremyRand                |          Owner:  tbb-team
     Type:  enhancement               |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-rbm                   |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by JeremyRand):

 Patch at https://notabug.org/JeremyRand/tor-browser-build/src/build-go-
 lib-exe (commit hash 690a8334a7c7c3e7db40f09783da7096d5ab4c56).  There was
 indeed a lot of boilerplate / duplicated code present in
 meek/obfs4/snowflake, and I think this patch does a reasonably good job of
 improving the situation.  I definitely find the code easier to read with
 this patch applied, though admittedly this is subjective and I'm probably
 biased toward finding code that I wrote easy to read.

 Feel free to review.  I've tested all of the build targets that I could
 think of to make sure that it builds without errors and that the outputs
 of meek/obfs4/snowflake look sane when untarred, but I haven't tested the
 resulting Tor Browser binaries.

 As a side note, this patch would make my life easier with regards to
 #30558, since solving that ticket involves adding another Go executable,
 which exacerbates the code duplication issues unless this patch is
 applied.  (I'm not familiar enough with Trac culture to know how to tag
 that relationship, or whether I even have the needed privs to do so.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30334#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online