[tor-bugs] #29670 [Core Tor/Tor]: Could not create SOCKS args string

[Tor Bug Tracker & Wiki]

#29670: Could not create SOCKS args string
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  035-backport, 040-backport, ux,      |  Actual Points:  .2
  regression?, 041-should,                       |
Parent ID:                                       |         Points:  .5
 Reviewer:  catalyst                             |        Sponsor:
                                                 |  Sponsor19
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:27 nickm]:
 > Added `bug29670_041` with PR at
 https://github.com/torproject/tor/pull/1072 to merge it forward to master
 and add practracker exceptions.  The branch for older series is still
 `bug29670_035`.
 Thanks! Looks good now. (after adjusting the 035 base branch for
 https://github.com/torproject/tor/pull/1056) I manually tested the 041
 branch with Tor Browser and an SSH SOCKS proxy, but I don't have an easy
 way to test a SOCKS5 proxy that requires authentication.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29670#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online