[tor-bugs] #29746 [Core Tor/Tor]: Improve Tor best practices tracker

[Tor Bug Tracker & Wiki]

#29746: Improve Tor best practices tracker
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  practracker, tech-debt,              |  Actual Points:  .1
  refactoring, easy, 041-deferred-20190530,      |
  network-team-roadmap-july                      |
Parent ID:                                       |         Points:  3
 Reviewer:  teor, ahf                            |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready
 * reviewer:  teor => teor, ahf


Comment:

 Non-blocking question: Why do we want to allow \t in #include statements
 (from commit 86d3d310f529bc1e13ce1ca5013c674837c9856b) ?

 I think the code looks good, it's well split up and nothing crazy is going
 on. Being able to temporarily disable it in our build system is something
 I've wanted for a while, so that feature is very welcomed!

 I'm going to say good to it here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29746#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online