[tor-bugs] #30585 [Applications/Tor Browser]: Provide standalone clang 8 project usable across all platforms

[Tor Bug Tracker & Wiki]

#30585: Provide standalone clang 8 project usable across all platforms
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, ff68-esr,                   |  Actual Points:
  TorBrowserTeam201907R, GeorgKoppen201907,      |
  tbb-9.0-must-nightly                           |
Parent ID:  #28716                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by boklm):

 Replying to [comment:1 gk]:
 > `bug_30585` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_30585&id=6af8cc6de4010ff0011a55dcefb4927e9e389872)
 in my `tor-browser-build` repo has a patch for review.

 This patch looks good to me.

 In branch `bug_30585` I added some minor improvements in fixup patches:

 - With https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_30585&id=aceef52a65523cec2ad4d97dae0c885e2e94dc09
 we define `gpg_keyring` and `sig_ext` at the top of the file so we don't
 need to do it for each input files.
 - with https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_30585&id=f0c2046ecf2e9da1574ddd6d67395fa67399b00e
 we move all the patch into a `win-patches` directory, so we don't need to
 list all patches individually. We also use `git apply` instead of `patch`
 so we don't need to handle the binary file `bigobj.o.gz` separately. This
 required fixing paths in some of the patches as `git apply` doesn't like
 them. Looking at `tor-browser/build/build-clang/build-clang.py` I also see
 that mozilla is using `patch` to apply the patches, so I'm wondering how
 it works for them.

 I squashed those two fixup commits in branch `bug_30585_v2`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_30585_v2&id=4c2b3a98e04605ce7fcbd1c2c7c4864c6a5125a2

 If you agree with those changes, I think it is ready to merge.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30585#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online