[tor-bugs] #30429 [Applications/Tor Browser]: Rebase Tor Browser patches for Firefox ESR 68

[Tor Bug Tracker & Wiki]

#30429: Rebase Tor Browser patches for Firefox ESR 68
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  TorBrowserTeam201907, tbb-9.0-must-  |  Actual Points:
  nightly                                        |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mcs):

 Replying to [comment:13 gk]:
 > mcs/brade: to not lose this in the previous wall of text: I thought it
 could be helpful if you'd had a second look at commits
 >
 > 45072c2fea6a535a712ac0888f12f881393cccbd

 R.e. the `char16_t` question: a while ago, Mozilla changed
 `FormatStringFromName()` to take a
 `const char *` so the new code is good.

 R.e. gk's second comment: Kathy and I would prefer to always initialize
 `profileStatus` (seems safer).

 R.e. gk's last comment about possibly adding an another call to
 `CheckProfileWriteAccess()`: we think it is OK to skip this case.

 In the `ProfileErrorDialog()` function, please reinstate the `rv` check
 for the call to `sb->FormatStringFromName()` (I think it was lost during a
 previous rebase).

 In `nsToolkitProfileService::SelectStartupProfile()` the first call to
 `GetProfileByName()` is wrong. We should not be passing a path to that
 function (it looks like the ESR60 patch is wrong too). Instead, once we
 obtain `lf`, we should call `CheckProfileWriteAccess(lf)`. In other words,
 we can remove the entire chunk that contains the first call to
 `GetProfileByName()` as well as a call to
 `CheckProfileWriteAccess(profile)` and
 instead make the second call earlier.

 Also, Mozilla has made several changes to these files since Alex started
 the ESR68 TB rebasing work. Kathy and I would like to take another look at
 the patch after those changes have been accounted for.


 > 9d8ca4380e947c2097d0fd3554b1f3dad20de634

 It looks like event listeners are handled by via the `LEGACY_ACTORS`
 object. See the large comment near the beginning of
 `toolkit/modules/ActorManagerParent.jsm`. If that is correct, we should
 remove the `removeMessageListener()` and `removeEventListener()` calls
 from `browser/actors/AboutTBUpdateChild.jsm`.

 R.e. `isAboutTBUpdate()`, that is replaced by the `matches` property
 within the `LEGACY_ACTORS` object.

 R.e. `BrowserContentHandler.jsm` being moved to `EXTRA_PP_COMPONENTS`:
 that was part of the #4234 patch.

 Otherwise, this looks good. We will need to test it once the other updater
 patches have been rebased.

 > 5269df12586ac7e4e45803a0f1b8c15da9ef529a

 This looks good to us, although testing is required. The reason the
 `EXTRA_PP_JS_MODULES` change appears in this patch is because a similar
 change is included in the #4234 patch (which was applied before this
 patch).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30429#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online