[tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton TorBrowserTeam201907R  |  Actual Points:
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by acat):

 * keywords:  tbb-torbutton => tbb-torbutton TorBrowserTeam201907R
 * status:  new => needs_review


Comment:

 Some changes for review here:
 https://github.com/acatarineu/torbutton/commits/28745 (starting from
 6023e0875c8085a58e6269801113a2a4600cb6d3, which is the last commit from
 #10760 patch). Corresponding tor-browser changes here:
 https://github.com/acatarineu/tor-browser/commits/28745 (last 4 commits).

 Some comments:

 Remove cookie-jar-selector component
   - For `browser.privatebrowsing.autostart = true`, cookie-jar-selector
 does nothing currently, so for new identity we just `clearCookies()`.
   - For `browser.privatebrowsing.autostart = false`, some cookies json
 files are stored in the browser profile folder, which we clear on startup
 in the patch.
 Bug 30851: Move default preferences to 000-tor-browser.js
   - This has a corresponding patch in tor-browser.
 Bug 30888: move torbutton_util.js to modules/utils.js
   - This also has a corresponding patch in tor-browser, to stop including
 torbutton_util.js in browser.xul.
 Make torbutton_open_network_settings global
   - This will have to be called somewhere in UI at some point, for now we
 just expose it.
 Refactor code to always use tor-control-port.js
   - Trying to use a single implementation of tor controller. Perhaps next
 step would be to do the same with tor-launcher.
   - The code had to be adapted a bit, since tor-control-port.js is async
 while previous impl. was sync.
 Remove versioncheck from torbutton.js
   - I'm assuming we don't need this, with the browser updater and having
 removed the blinking notification in torbutton UI. But perhaps we still
 want as telemetry, not sure.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28745#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online