[tor-bugs] #24964 [Core Tor/Tor]: dos: Block single hop client at the HSDir

[Tor Bug Tracker & Wiki]

#24964: dos: Block single hop client at the HSDir
--------------------------------------+------------------------------------
 Reporter:  dgoulet                   |          Owner:  dgoulet
     Type:  defect                    |         Status:  needs_review
 Priority:  Medium                    |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor              |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tor-dos, tor2web, tor-hs  |  Actual Points:  0.4
Parent ID:  #24962                    |         Points:  0.1
 Reviewer:  asn                       |        Sponsor:  Sponsor27-must
--------------------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:18 dgoulet]:
 > Replying to [comment:17 teor]:
 > > Do we need to check for "marked for close" on the circuit or channel
 as well?
 >
 > I'm not entirely sure actually... If the circuit or channel is closed,
 the descriptor will never be sent back. But if the edge connection is
 closed, then we sorta need to also deny the request even though it is not
 really suppose to happen...
 >
 > Thoughts?

 Let's do the closed and mark for closed checks, but BUG() if they ever
 happen?
 Then we can switch the ones that do happen to info logs.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24964#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online