[tor-bugs] #30934 [Circumvention/Snowflake]: Add a "Turn Off/On" toggle

[Tor Bug Tracker & Wiki]

#30934: Add a "Turn Off/On" toggle
-------------------------------------+-----------------------------
 Reporter:  arlolra                  |          Owner:  cohosh
     Type:  defect                   |         Status:  merge_ready
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  snowflake-webextension   |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  arlolra                  |        Sponsor:
-------------------------------------+-----------------------------
Changes (by arlolra):

 * status:  needs_review => merge_ready


Comment:

 > Okay here are two more commits for ...

 On the whole, these changes seem fine.  I left two comments on the pull.

 > This is the same case as the current webpage snowflake.torproject.org.
 We could perhaps add some more obvious instructions to enable it if it's a
 usability problem.

 I agree with the cypherpunk that it should default to "on" since this
 isn't the same as browsing to a webpage that potentially has a snowflake
 embed and could start proxying traffic against the user's will; here we
 have explicit interaction of installing the extension.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30934#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online