[tor-bugs] #30864 [Core Tor/Tor]: Move variable manipulation code out of confparse.c

[Tor Bug Tracker & Wiki]

#30864: Move variable manipulation code out of confparse.c
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  enhancement   |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  2.5
Parent ID:  #29211        |         Points:  1
 Reviewer:  catalyst      |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Thanks! The code changes look good. I made a few minor comments on the
 pull request.

 There's a mismatched Doxygen comment that should be corrected. There's a
 minor function naming comment that you may ignore if you like.

 There's also a technical debt comment that I'm OK with you opening a new
 ticket about.

 We talked about the broader documentation issues with this code over IRC.
 I will open a new ticket to improve those once the dust has settled from
 the other related work on this branch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30864#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online