[tor-bugs] #29100 [Core Tor/Fallback Scripts]: Update src/app/config/fallback_dirs.inc to ../tor/src/app/config/fallback_dirs.inc post-split
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Jul 2 19:26:44 UTC 2019
#29100: Update src/app/config/fallback_dirs.inc to
../tor/src/app/config/fallback_dirs.inc post-split
---------------------------------------+-----------------------------
Reporter: teor | Owner: (none)
Type: enhancement | Status: merge_ready
Priority: Medium | Milestone:
Component: Core Tor/Fallback Scripts | Version:
Severity: Normal | Resolution:
Keywords: fallback | Actual Points: 2
Parent ID: #28793 | Points: 1
Reviewer: nickm | Sponsor:
---------------------------------------+-----------------------------
Changes (by nickm):
* status: needs_review => merge_ready
Comment:
This looks good to me.
As a followup, I suggest changing the definition of `getvar_conf()` so
that on error, it gives a more useful explaining what the problem is, and
changing the definition of `opt()` so that it turns the empty string
and/or a missing option into None, but reports errors otherwise.
That isn't super-urgent, though, since these scripts are only run by
developers.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29100#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list