[tor-bugs] #28672 [Circumvention/Snowflake]: Android reproducible build of Snowflake

[Tor Bug Tracker & Wiki]

#28672: Android reproducible build of Snowflake
-------------------------------------------------+-------------------------
 Reporter:  dcf                                  |          Owner:  (none)
     Type:  project                              |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Circumvention/Snowflake              |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm,                 |  Actual Points:
  GeorgKoppen201904, ex-sponsor-19,              |
  TorBrowserTeam201907                           |
Parent ID:  #30318                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor28-can
-------------------------------------------------+-------------------------

Comment (by boklm):

 Replying to [comment:24 gk]:
 > 3) What's the reason for moving the `gclient config` part outside of the
 `if [ ! -d "src"]` one, in particular as this affects non-Android
 platforms as well. And what does it mean? That it is
 > not run for Linux and macOS anymore?

 If the `gclient config` is behind the `if [ ! -d "src"]`, then changes to
 gclient config are not taken into account unless we remove the `src`
 directory. So moving it outside allows us to update this config without
 removing the `src` directory.

 It seems we should have a patch moving that part outside of the `if [ ! -d
 "src"]` on the stable branch too, otherwise building master will update
 the gclient config, and then building stable will keep using the master
 version of the gclient config.

 The `target_os` line means fetching dependencies specific for those
 platforms. It seems we don't need specific dependencies for the Linux and
 macOS builds as we had no `target_os` defined before.

 With this change we will fetch Android dependencies (and Windows ones, but
 we can remove it for now), and will include it in the webrtc tarball used
 for every platforms. This means we include some dependencies not needed in
 the Linux and macOS builds, but this avoids generating one tarball for
 each platform.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28672#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online