[tor-bugs] #30683 [Applications/Tor Browser]: Properties in dom/locales/$lang/chrome/ allow detecting user locale

[Tor Bug Tracker & Wiki]

#30683: Properties in dom/locales/$lang/chrome/ allow detecting user locale
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-fingerprinting-locale,           |  Actual Points:
  TorBrowserTeam201907                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * cc: mcs, brade (added)
 * status:  needs_review => needs_revision
 * keywords:  tbb-fingerprinting-locale, TorBrowserTeam201907R => tbb-
     fingerprinting-locale, TorBrowserTeam201907


Comment:

 I think this looks mostly good to me. Could you adapt
 `// When we spoof English, use en-US default strings in HTML forms.` a bit
 as the code that follows is not only about forms anymore?

 Have you checked whether the patch is a good upstreaming idea as-is? I
 wonder in particular if the `en-US` strings will always be available in,
 say `fr`, builds that don't come with `fr` lang packs.

 mcs, brade could you have a second look?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30683#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online