[tor-bugs] #28976 [Core Tor/Tor]: git pre-commit hook that runs 'make check-spaces' and 'make check-changes'

[Tor Bug Tracker & Wiki]

#28976: git pre-commit hook that runs 'make check-spaces' and 'make check-changes'
--------------------------+------------------------------------
 Reporter:  rl1987        |          Owner:  rl1987
     Type:  enhancement   |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  nickm         |        Sponsor:
--------------------------+------------------------------------
Changes (by rl1987):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:5 nickm]:
 > Looks good, but are a few issues I see:
 >
 > 1. If Tor is configured for out-of-tree builds, or configure hasn't run,
 then there won't actually be a Makefile in the top level directory.
 >
 > (Suggested solutions: either we should check whether Makefile exists
 (risky), or run the several check scripts directly without using the
 Makefile.)

 Running scripts directly in aecd176f6e6254ac18e7eadd637695c7df6a8ee9.

 >
 > 2. For recent versions, I'd like to run "check-includes" as well. (That
 script does not exist before 0.3.5, though.)
 >
 > (The right solution here will depend on what we decide to do for issue 1
 above.)
 >

 Running checkIncludes.py in 0a40aa0d2cac30a46debef38e8ff1aa00f52515e.

 > 3. For branches based on 0.2.9, "check-changes" won't pass.
 >
 > (I went and fixed this in dd6c2b0ad77b5bfbf7f06b1d73f8ab85d81154bf.)
 >
 > 4. The changes file should mention where the script is.
 >
 > (To fix this we can just add the patch to the changes files.)
 >
 > Moving this ticket into 0.4.0.x, since I think we can safely take this
 there once it's ready.

 Fixed in 6a1ae1294ad8a2f1412c87db767dd72bbefa7cd4.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28976#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online