[tor-bugs] #28932 [Core Tor/sbws]: Detect when sbws stalls and log backtrace

[Tor Bug Tracker & Wiki]

#28932: Detect when sbws stalls and log backtrace
---------------------------+-----------------------------------
 Reporter:  juga           |          Owner:  (none)
     Type:  defect         |         Status:  merge_ready
 Priority:  Medium         |      Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |        Version:  sbws: 1.0.2
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:  #28663         |         Points:
 Reviewer:  dgoulet        |        Sponsor:
---------------------------+-----------------------------------
Changes (by juga):

 * status:  needs_revision => merge_ready


Comment:

 Replying to [comment:3 dgoulet]:
 > I think we should make `36` value into some sort of constant because it
 isn't clear what is that value but also it is repeated twice.
 >
 > I had to read the loop above to get that it is every 5 seconds and thus
 36 is for 3 minutes. Either adding a clearer comment linking the two or
 making it a constant and comment there.

 Added a constant.
 >
 > The other thing is that, don't you want to exit after the bug is
 detected or it will recover from the mistake?

 No, the error doesn't recover. I changed the code so that it exits unless
 the debugging level is log (more verbose) so that it continues
 instanciating a Python Debugger (for developers to debug the error).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28932#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online