[tor-bugs] #29050 [Core Tor/Torsocks]: Connecting to tor over a socks 5 connection no longer works in 3.5.7

[Tor Bug Tracker & Wiki]

#29050: Connecting to tor over a socks 5 connection no longer works in 3.5.7
--------------------------+-----------------------------------
 Reporter:  arj           |          Owner:  dgoulet
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Component:  Core Tor/Torsocks
  Version:  Tor: 0.3.5.7  |       Severity:  Normal
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+-----------------------------------
 Hi

 I upgraded tor today on my machine and found that I can no longer connect
 over a socks 5 connection. I'm using this node library
 https://github.com/JoshGlazebrook/socks and it has been working with no
 problems before (0.3.4 and earlier). But after upgrading I'm seeing:
 Socks5 proxy rejected connection - Failure when connecting and it syslog I
 see:

 Jan 10 21:58:22 chrx Tor[11218]: socks5: parsing failed - invalid
 user/pass authentication message.
 Jan 10 21:58:22 chrx Tor[11218]: Fetching socks handshake failed. Closing.

 Changing the config to use socks 4 seems to work.

 The project I'm working that uses this is scuttlebutt. And the code doing
 the onion connection locally is here:

 https://github.com/ssbc/multiserver/blob/master/plugins/onion.js

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29050>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online