[tor-bugs] #28142 [Core Tor/Tor]: Merge original WTF-PAD branch

[Tor Bug Tracker & Wiki]

#28142: Merge original WTF-PAD branch
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:
                                                 |  mikeperry
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,        |  Actual Points:
  padding                                        |
Parent ID:  #28631                               |         Points:
 Reviewer:  asn                                  |        Sponsor:
                                                 |  Sponsor2
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:29 nickm]:
 > Okay, I've been over pr 624.  I think it's nearly ready; I just want to
 double-check a few things with you here.  In many cases, just opening a
 followup ticket and attaching a link should be good enough, though we
 should talk about "necessary for 0.4.0" vs "can wait".

 Thanks for the review.

 I went through all the new review comments and provided fixups to most of
 them.

 There is only one comment I'm not sure what to do with, and that's the one
 about using non-coarse monotime in various places. Feedback would be
 appreciated:
 https://github.com/torproject/tor/pull/624#discussion_r246443113

 Also, Mike what do you want to do with the TODO file?

 Other than that, I think we are good to go here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28142#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online