[tor-bugs] #28058 [Core Tor/Tor]: Run shellcheck as part of "make check"
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Jan 8 22:17:28 UTC 2019
#28058: Run shellcheck as part of "make check"
----------------------------+------------------------------------
Reporter: teor | Owner: rl1987
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: technical-debt | Actual Points:
Parent ID: | Points:
Reviewer: mikeperry | Sponsor:
----------------------------+------------------------------------
Changes (by mikeperry):
* status: merge_ready => needs_revision
Comment:
Actually, you know what.. Can we fix the formatting in that makefile rule,
and maybe comment that the command -v thing is checking for shellcheck
before running it? The fact that Nick missed that is probably a sign this
code is too dense right now.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28058#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list