[tor-bugs] #28866 [Core Tor/sbws]: ResultDump.queue.put() can hang if the queue is full

[Tor Bug Tracker & Wiki]

#28866: ResultDump.queue.put() can hang if the queue is full
---------------------------+-----------------------------------
 Reporter:  teor           |          Owner:  (none)
     Type:  defect         |         Status:  needs_review
 Priority:  Medium         |      Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |        Version:  sbws: 1.0.2
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:  #28663         |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+-----------------------------------
Changes (by juga):

 * status:  new => needs_review


Comment:

 Replying to [comment:2 juga]:
 > > So sbws should call put() without blocking, or with a (very small)
 timeout:
 > > https://docs.python.org/3/library/queue.html#queue.Queue.put
 >
 > With put timeout it will always return Full unless the slot is
 immediatly available
 (https://docs.python.org/3/library/queue.html#queue.Queue.put)

 i miss-interpreted this, it doesn't return Full.

 Implemented the timeout in check whether the queue is full:
 https://github.com/torproject/sbws/pull/325

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28866#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online