[tor-bugs] #28995 [Core Tor/Tor]: Fix the IPv6 case of tor_ersatz_socketpair

[Tor Bug Tracker & Wiki]

#28995: Fix the IPv6 case of tor_ersatz_socketpair
---------------------------+------------------------------------
 Reporter:  kjak           |          Owner:  (none)
     Type:  defect         |         Status:  needs_review
 Priority:  Medium         |      Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor   |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:  035-backport?  |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------------------

Comment (by kjak):

 I think it should be backported.  `get_local_listener` is called with
 AF_INET6 on IPv6-only systems, so it appears that `tor_ersatz_socketpair`
 is broken there (but I have not directly tested on such a system).

 I want to avoid making this more complicated than it needs to be, but I'm
 a bit confused on how this works here.  Should I make a new PR based on
 maint-0.3.5 and keep the current PR (based on master) open?  Or should I
 close the latter one?  Or something else?

 I can take a crack at making a changes file and including it in whatever
 PRs are open.

 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28995#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online