[tor-bugs] #17357 [Core Tor/Tor]: rend_service_relaunch_rendezvous() ignores hs_service_requires_uptime_circ()

[Tor Bug Tracker & Wiki]

#17357: rend_service_relaunch_rendezvous() ignores
hs_service_requires_uptime_circ()
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  neel
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-hs        |  Actual Points:
Parent ID:                |         Points:  0.5
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by neel):

 * status:  needs_revision => needs_review


Comment:

 I have moved the `base32_encode()` call into the `if (!service)`
 statement.

 I could not move the `rend_pk_digest()` call into the statement because
 it's needed by `rend_service_get_by_pk_digest()` to fill in `service`
 which is needed by `hs_service_requires_uptime_circ()`.

 These changes have been pushed and I am setting this as needs review.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17357#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online