[tor-bugs] #29221 [Core Tor/Tor]: Tooling to track code-style/best-practices violations

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Feb 26 12:22:59 UTC 2019


#29221: Tooling to track code-style/best-practices violations
--------------------------------------------+------------------------------
 Reporter:  nickm                           |          Owner:  (none)
     Type:  defect                          |         Status:  new
 Priority:  Medium                          |      Milestone:
Component:  Core Tor/Tor                    |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  network-team-roadmap-2019-Q1Q2  |  Actual Points:
Parent ID:                                  |         Points:  3
 Reviewer:                                  |        Sponsor:
                                            |  Sponsor31-can
--------------------------------------------+------------------------------

Comment (by nickm):

 Hi, George!

 I think that the function/file length thing I mentioned was just ad hoc
 one-liners, like `find src/ -name '*.[ch]' | xargs wc -l |sort -n` and
 like whatever I used for cyclomatic complexity in #6313.

 I think you should feel free to go with whatever fruit seems lowest-
 hanging here.  `complexity` seems like a good start for measurement, but I
 don't see immediately how to use it for enforcing rules.  What do you
 think there?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29221#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list