[tor-bugs] #28636 [Core Tor/Tor]: Address WTF-PAD comments by Nick (2018-11-27 over IRC)

[Tor Bug Tracker & Wiki]

#28636: Address WTF-PAD comments by Nick (2018-11-27 over IRC)
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,        |  Actual Points:
  padding, 041-proposed                          |
Parent ID:  #28632                               |         Points:  3
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor2
-------------------------------------------------+-------------------------
Changes (by asn):

 * points:  2 => 3


Comment:

 I will overload this ticket by adding another thing we should fix to
 improve code quality: We could use the probability distribution structs
 directly instead of the generic `circpad_distribution` abstraction, to
 reduce the possibility of messing up prob distr parameters like we did in
 #29527. Also see Riastradh's comment in
 https://trac.torproject.org/projects/tor/ticket/29527?replyto=13#comment:13.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28636#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online