[tor-bugs] #29057 [Core Tor/sbws]: Adapt bandwidth file classes to be compatible with stem (descriptors, etc) documents
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Feb 25 17:33:09 UTC 2019
#29057: Adapt bandwidth file classes to be compatible with stem (descriptors, etc)
documents
---------------------------+-----------------------------------
Reporter: juga | Owner: juga
Type: defect | Status: assigned
Priority: Medium | Milestone: sbws: 1.1.x-final
Component: Core Tor/sbws | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: #28684 | Points:
Reviewer: | Sponsor:
---------------------------+-----------------------------------
Comment (by juga):
After checking stem's implementation, it could be used in sbws for:
- parsing existing bandwidth files: this would be useful for tests and
creating graphs (made with script outside of sbws package), though
there're already methods in sbws implementing this and to use stem's one,
sbws will need to implement methods that take as input the dictionaries
stem creates.
- generate the bandwidth file: this is would be more useful, though it's
also already implemented in sbws and sbws would need to implement methods
to pass to stem the data in the format it needs (dictionaries).
To don't depend on the stem implementation until it's released, i think
this might be moved to a later milestone.
What it can still be changed in stem, is the way the headers and bandwidth
lines attributes are declared, which specify the type for each attribute
(https://gitweb.torproject.org/stem.git/tree/stem/descriptor/bandwidth_file.py#n61).
The header could just be a copy of what is implemented in stem (until
released).
However, the bandwidth lines are not converted to their types, just parsed
from/to strings, so this would be a new way to declare the bandwidth
lines.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29057#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list