[tor-bugs] #29573 [Core Tor/Tor]: Tests fail without network interface configured

[Tor Bug Tracker & Wiki]

#29573: Tests fail without network interface configured
--------------------------+------------------------------
 Reporter:  atsampson     |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Low           |      Component:  Core Tor/Tor
  Version:  Tor: 0.3.5.8  |       Severity:  Normal
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------
 I build packages on Linux as an unprivileged user inside a network
 namespace with no interfaces configured (to catch packages that try to use
 Internet resources during the build process). With tor 0.3.5.7 and
 earlier, this worked fine and the test suite passed completely.

 With tor 0.3.5.8, three test cases fail:

 {{{
 address/get_if_addrs_list_internal: Feb 24 12:59:28.031 [err] connect()
 failed: Network is unreachable
   [get_if_addrs_list_internal FAILED]
 address/get_if_addrs_list_no_internal: Feb 24 12:59:28.040 [err] connect()
 failed: Network is unreachable
   [get_if_addrs_list_no_internal FAILED]
 address/get_if_addrs: Feb 24 12:59:28.309 [err] connect() failed: Network
 is unreachable
   [get_if_addrs FAILED]
 }}}

 Here's strace output for one of the failures:

 {{{
 socket(AF_INET, SOCK_DGRAM|SOCK_CLOEXEC, IPPROTO_UDP) = 6
 connect(6, {sa_family=AF_INET, sin_port=htons(9),
 sin_addr=inet_addr("18.0.0.1")}, 16) = -1 ENETUNREACH (Network is
 unreachable)
 }}}

 So this looks like get_interface_address6_via_udp_socket_hack failing -
 comments in the tests suggest that they ought to be getting an empty list
 rather than an error in this circumstance?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29573>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online