[tor-bugs] #29552 [Core Tor/Tor]: memory leak: protover_contains_long_protocol_names in protover.c calls parse_protocol_list, but doesn't free smartlist returned (treats it as a boolean)
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Feb 21 15:05:36 UTC 2019
#29552: memory leak: protover_contains_long_protocol_names in protover.c calls
parse_protocol_list, but doesn't free smartlist returned (treats it as a
boolean)
---------------------------+------------------------------
Reporter: drjohnson1984 | Owner: (none)
Type: defect | Status: closed
Priority: High | Milestone:
Component: Core Tor/Tor | Version: Tor: 0.3.3.7
Severity: Normal | Resolution: invalid
Keywords: memory-leak | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
---------------------------+------------------------------
Comment (by drjohnson1984):
The code looked like this in 0.3.3.7:
bool
protover_contains_long_protocol_names(const char *s)
{
if (!parse_protocol_list(s))
return true;
return false;
}
Because we modify source for internal testing and use, we only
infrequently merge in versions. I figured this would have generated a bug
report at some point to go with the fix, but I guess not. Sorry to have
bothered you
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29552#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list