[tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load extremely
slowly or become unplayable
-------------------------------------------------+-------------------------
 Reporter:  QZw2aBQoPyuEVXYVlBps                 |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-        |  Actual Points:
  website, TorBrowserTeam201902                  |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  tbb-disk-leak, tbb-usability-website, TorBrowserTeam201902R =>
     tbb-disk-leak, tbb-usability-website, TorBrowserTeam201902
 * status:  needs_review => needs_revision


Comment:

 You have
 {{{
  if (aContentLength < 0) {
 }}}
 in your patch but looking at the original code I think we should take care
 of the case here as well that `aContentLength` is `0`.

 Additionally, I think we should go back to the default size for
 `media.cache_size` so that users outside of private browsing mode get the
 usual behavior (right now they would still be affected by this bug without
 resetting the pref). (https://gitweb.torproject.org/tor-
 browser.git/tree/browser/app/profile/000-tor-browser.js?h=tor-
 browser-60.5.0esr-8.5-1 is the file to look at)

 QZw2aBQoPyuEVXYVlBps: Thanks for this find and a patch, really
 appreciated. We are close here. Do you want to fix the remaining things up
 or should we? How should we credit you? (I am fine crediting
 QZw2aBQoPyuEVXYVlBps in the commit message :) )

 pospeselr: Could you open a ticket at Mozilla's bug tracker with the
 attached patch and find out whether Mozilla would take it (even somewhat
 modified)?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29120#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online