[tor-bugs] #29244 [Core Tor/Tor]: Travis permissions error: failed to write Cargo.lock

[Tor Bug Tracker & Wiki]

#29244: Travis permissions error: failed to write Cargo.lock
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  041-proposed, tor-ci, regression,    |  Actual Points:  .2
  040-backport 035-backport 034-backport         |
  033-backport                                   |
Parent ID:                                       |         Points:  0.5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 Replying to [comment:7 teor]:
 > Cargo recently started adding a comment to the start of the file:
 > https://github.com/rust-
 lang/cargo/commit/3de188f1399da693c57054ed425bc0289752edd1
 >
 > But cargo checks for frozen before writing. We are getting the write
 failed error, not the frozen error.
 > https://github.com/rust-
 lang/cargo/blob/3de188f1399da693c57054ed425bc0289752edd1/src/cargo/ops/lockfile.rs#L105

 For posterity, the above comments are where the fix comes from.
 {{{
 <ahf> armadev: the problem is that the place where tor.git is located is
 read/only, when we run distcheck it runs cargo which modifies the file by
 adding those two comments
 <ahf> but because it's read-only it will fail
 <ahf> but if those two lines of comment is there cargo wont touch the file
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29244#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online